Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwrite 'msbuild_toolset' only if 'toolset' is defined #1242

Merged
merged 1 commit into from
Nov 11, 2019

Commits on Nov 5, 2019

  1. overwrite 'msbuild_toolset' only if 'toolset' is defined

    node-gyp uses 'msbuild_toolset' in 'target_defaults' to specify what
    toolset should be used, according to what version of Visual Studio
    was detected.
    
    Before this change, when 'toolset' was not specified, node-sqlite3
    failed to compile with any version of Visual Studio after 2015,
    because gyp fails to detect the toolset correctly.
    
    With this change 'toolset' is only used if defined, fixing
    compilation with node-gyp and recent VS versions.
    joaocgreis committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    f2f3b7d View commit details
    Browse the repository at this point in the history