Add openssl_fips to binding.gyp #1684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix this issue nodejs/node-gyp#2673 (comment)
|
Seconding this, would be nice to have latest install without downgrading node-gyp. |
|
Can someone explain why this is needed, or at least provide a repro to show the breaking case? |
Its really an obligatory fix due to the latest node versions not playing nicely with node-gyp. I personally am now using an older version(node-sqlite3 5.1.6) to bypass this issue, as it seems the issue is some breaking feature in 5.1.7. I'm fairly new to node-gyp, so I can't really give an explanation as to why this fixes it. The really fun part is, downgrading node to lts variants or even older releases does not remove this error... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this issue
nodejs/node-gyp#2673 (comment)