Skip to content

Commit

Permalink
- Switch const to let except with require/importFrom and all-…
Browse files Browse the repository at this point in the history
…cap constants
  • Loading branch information
brettz9 committed Oct 25, 2019
1 parent 5328b43 commit 072ff49
Show file tree
Hide file tree
Showing 8 changed files with 28 additions and 28 deletions.
4 changes: 2 additions & 2 deletions lib/rules/missing-assertion.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
module.exports = function(context) {
return {
ExpressionStatement(node) {
const {expression} = node;
let {expression} = node;
if (expression.type !== 'CallExpression')
return;

const {callee} = expression;
let {callee} = expression;
if (callee.type === 'Identifier' && callee.name === 'expect') {
context.report({
node,
Expand Down
10 changes: 5 additions & 5 deletions lib/rules/no-inner-compare.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@ const HINTS = {
module.exports = function(context) {
return {
ExpressionStatement(node) {
const {expression} = node;
let {expression} = node;
if (expression.type !== 'MemberExpression' && expression.type !== 'CallExpression')
return;

const expect = findExpectCall(expression);
let expect = findExpectCall(expression);
if (!expect)
return;

const args = expect.arguments;
const [firstArgument] = args;
let args = expect.arguments;
let [firstArgument] = args;
if (!firstArgument || firstArgument.type !== 'BinaryExpression')
return;

const hint = HINTS[firstArgument.operator];
let hint = HINTS[firstArgument.operator];
if (!hint)
return;

Expand Down
22 changes: 11 additions & 11 deletions lib/rules/terminating-properties.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,33 +14,33 @@ const PROPERTY_TERMINATORS = [
];

module.exports = function(context) {
const options = context.options[0] || {};
const additionalTerminators = options.properties || [];
const validTerminators = [...PROPERTY_TERMINATORS, ...additionalTerminators];
let options = context.options[0] || {};
let additionalTerminators = options.properties || [];
let validTerminators = [...PROPERTY_TERMINATORS, ...additionalTerminators];

return {
ExpressionStatement(node) {
const {expression} = node;
let {expression} = node;
if (expression.type !== 'CallExpression')
return;

const {callee} = expression;
let {callee} = expression;
if (callee.type !== 'MemberExpression')
return;

const {property} = callee;
let {property} = callee;
if (property.type !== 'Identifier' || !validTerminators.includes(property.name))
return;

const expectCall = findExpectCall(callee.object);
let expectCall = findExpectCall(callee.object);
if (!expectCall)
return;

const source = context.getSourceCode();
let source = context.getSourceCode();

const calleeText = source.getText(callee);
const expectText = source.getText(expectCall);
const assertionText = calleeText.substr(expectText.length + 1);
let calleeText = source.getText(callee);
let expectText = source.getText(expectCall);
let assertionText = calleeText.substr(expectText.length + 1);

context.report({
node: property,
Expand Down
2 changes: 1 addition & 1 deletion tests/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const assert = require('assert');
const fs = require('fs');
const path = require('path');

const rules = fs.readdirSync(path.resolve(__dirname, '../lib/rules/'))
let rules = fs.readdirSync(path.resolve(__dirname, '../lib/rules/'))
.map((f) => {
return path.basename(f, '.js');
});
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/missing-assertions.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const rule = require('../../../lib/rules/missing-assertion');
const {RuleTester} = require('eslint');

const ruleTester = new RuleTester();
let ruleTester = new RuleTester();
ruleTester.run('missing-assertion', rule, {
valid: [{
code: [
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-inner-compare.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const rule = require('../../../lib/rules/no-inner-compare');
const {RuleTester} = require('eslint');

const ruleTester = new RuleTester();
let ruleTester = new RuleTester();
ruleTester.run('no-inner-compare', rule, {
valid: [{
code: 'expect(true).to.be.ok;'
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/terminating-properties.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const rule = require('../../../lib/rules/terminating-properties');
const {RuleTester} = require('eslint');

const ruleTester = new RuleTester();
let ruleTester = new RuleTester();
ruleTester.run('terminating-properties', rule, {
valid: [{
code: [
Expand Down
12 changes: 6 additions & 6 deletions tests/lib/util/find-expect-call.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ const findExpectCall = require('../../../lib/util/find-expect-call');

describe('find-expect-call util', function () {
it('Finds expect statements which are considered member expressions', function () {
const code = 'expect(true).to.be.ok;';
const ast = espree.parse(code);
const result = findExpectCall(ast.body[0].expression);
let code = 'expect(true).to.be.ok;';
let ast = espree.parse(code);
let result = findExpectCall(ast.body[0].expression);
expect(result).to.be.an('object');
});

it('Finds expect statements which are considered recursive call expressions', function () {
const code = 'expect(true).to.equal(true);';
const ast = espree.parse(code);
const result = findExpectCall(ast.body[0].expression);
let code = 'expect(true).to.equal(true);';
let ast = espree.parse(code);
let result = findExpectCall(ast.body[0].expression);
expect(result).to.be.an('object');
});
});

0 comments on commit 072ff49

Please sign in to comment.