-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-inner-literal
rule
#84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Oct 25, 2019
brettz9
force-pushed
the
no-inner-literal
branch
2 times, most recently
from
October 25, 2019 10:24
55b326a
to
904b8c3
Compare
Turbo87
reviewed
Oct 25, 2019
Turbo87
changed the title
- Add inner literal rule; fixes #17
Add Oct 25, 2019
no-inner-literal
rule
brettz9
force-pushed
the
no-inner-literal
branch
from
October 25, 2019 10:43
904b8c3
to
020b2ab
Compare
Turbo87
approved these changes
Oct 25, 2019
hmm, looks like some of the older ESLint versions are not happy about the |
brettz9
force-pushed
the
no-inner-literal
branch
from
October 25, 2019 12:19
1cdbd00
to
7fd091a
Compare
I could do a |
we could probably check |
brettz9
force-pushed
the
no-inner-literal
branch
2 times, most recently
from
October 25, 2019 13:33
e5e2f10
to
1b7a16f
Compare
Yeah, better idea... Done... |
And passing... |
brettz9
force-pushed
the
no-inner-literal
branch
3 times, most recently
from
October 25, 2019 13:49
71c985e
to
e129aaa
Compare
brettz9
force-pushed
the
no-inner-literal
branch
from
October 25, 2019 13:51
e129aaa
to
015dd18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17