Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open editor when clicking on notification [2] #63

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Gvozd
Copy link
Collaborator

@Gvozd Gvozd commented Dec 8, 2020

check list

  • check click event on different platforms
    • Linux / NotifySend
    • Linux / NotificationCenter
    • Windows <8 / WindowsBalloon
    • Windows >=8 / WindowsBalloon
    • Windows >=8 / WindowsToaster
    • WSL / WindowsToaster
    • BSD / NotifySend (non-critical)
    • MacOS / Growl (non-critical)
    • Windows / Growl (non-critical)
  • more examples in documentation for different popular editors/IDE
  • cover by tests
  • wait for release of bugfix node-notifier#347

how to try this

For testing this branch install dependency from github by one of commands:

yarn add -D Turbo87/webpack-notifier#open_editor_on_click
npm i -D Turbo87/webpack-notifier#open_editor_on_click

reporting

Also, please send in the comments some debugging information for your working computer:

  • run plugin
  • click on first notification
  • in the console you will get the webpack-notifier debug info message. copy it
  • modificate some your code, for generate new notification
    do not close him!!!
  • wait for the notification to hide itself
  • in the console you will get the webpack-notifier debug info message. copy it too
  • leave a comment indicating your OS, and debug information
  • also tell us if the new functionality works in general, and what problems you have 😄

@Gvozd
Copy link
Collaborator Author

Gvozd commented Dec 17, 2020

Windows 7 / WindowsBalloon

webpack-notifier debug info {notifier: 'WindowsBalloon', error: null, response: 'activate', metadata: [ {} ]}
webpack-notifier debug info {notifier: 'WindowsBalloon', error: null, response: 'close', metadata: [ {} ]}
webpack-notifier debug info {notifier: 'WindowsBalloon', error: null, response: 'close', metadata: [ {} ]}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants