Do not implement methods from Base #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 80.85% 88.09% +7.24%
==========================================
Files 1 1
Lines 47 42 -5
==========================================
- Hits 38 37 -1
+ Misses 9 5 -4
Continue to review full report at Codecov.
|
cpfiffer
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO we should not implement these methods since we do not provide a useful default implementation and stuff like
Base.hcat(c::AbstractChains...) = cat(c...; dims=2)will invalidate the default definition ofhcat()in Base (which might be related to TuringLang/MCMCChains.jl#171).