Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #114

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Some fixes #114

merged 3 commits into from
Jun 17, 2020

Conversation

devmotion
Copy link
Member

Some test issues in #113 were not fixed. It seems the problem is rather running the tests on Windows than on 32bit (or maybe both), and tests fail on Julia 1.0 since eachcol is not defined in the optional AD backends.

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   57.22%   57.22%           
=======================================
  Files          23       23           
  Lines        1169     1169           
=======================================
  Hits          669      669           
  Misses        500      500           
Impacted Files Coverage Δ
src/compat/reversediff.jl 1.31% <ø> (ø)
src/compat/tracker.jl 55.55% <ø> (ø)
src/compat/zygote.jl 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a72665d...2398d41. Read the comment docs.

@torfjelde
Copy link
Member

Sweet! But are now just disabling testing on Windows?

@devmotion
Copy link
Member Author

But are now just disabling testing on Windows?

I tried to only disable Windows (it was only added in the last PR and not tested before) but there were still memory issues in one of the 32bit tests (e.g., https://github.com/TuringLang/Bijectors.jl/runs/780512942), so I disabled Windows and 32bit for now. I'm still hoping that (at least parts of) the problem can be resolved by not using eval.

@devmotion
Copy link
Member Author

Finally all tests passed 🎉 Can we merge this and make a release, so that we can fix the issues with Distributions >= 0.23.3 in Turing and DynamicPPL? Since the c0 fixes are breaking, I assume the next release should be 0.8.0.

@yebai yebai merged commit 5216dd6 into master Jun 17, 2020
@yebai yebai deleted the fixes branch June 17, 2020 18:39
@yebai
Copy link
Member

yebai commented Jun 17, 2020

Finally all tests passed 🎉 Can we merge this and make a release, so that we can fix the issues with Distributions >= 0.23.3 in Turing and DynamicPPL? Since the c0 fixes are breaking, I assume the next release should be 0.8.0.

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants