Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace prob macro with SimpleVarInfo #356

Closed
yebai opened this issue Dec 16, 2021 · 2 comments · Fixed by #604
Closed

Replace prob macro with SimpleVarInfo #356

yebai opened this issue Dec 16, 2021 · 2 comments · Fixed by #604

Comments

@yebai
Copy link
Member

yebai commented Dec 16, 2021

See #309 (comment)

IMO this should be removed. Once we have SimpleVarInfo, this is completely redundant.

Similarly we should IMO remove the prob"..." macro, since now it will be possible to add something like

function logdensity(model::Model, theta::NamedTuple)
    return logdensity(model, SimpleVarInfo(theta))
end

It might be safer to depreciate logprob with a suggestion to use logdensity first. Also, we need to update the documentation on prob/logprob.

Related: #315 (comment) #325 (comment)

See also the | notation for models.

@yebai
Copy link
Member Author

yebai commented May 7, 2024

@sunxd3 can you take a look at this issue and see whether we can safely remove prob in favour of logprior, logjoint and loglikelihood functions?

@torfjelde
Copy link
Member

I'm very, very in favour of this! It's about time we deprecate the logprob macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants