Remove the prob and logprob macros

[sunxd3]

Fix #356.

With DynamicPPL's logjoint, logprior and loglikelihood, the macro based query functions are not needed anymore.

[coveralls]

Pull Request Test Coverage Report for Build 9099057865

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 38 unchanged lines in 5 files lost coverage.
• Overall coverage decreased (-0.9%) to 77.599%

---

Files with Coverage Reduction	New Missed Lines	%
src/model.jl	2	88.24%
src/utils.jl	5	76.81%
src/varinfo.jl	5	86.1%
src/context_implementations.jl	10	58.63%
src/threadsafe.jl	16	48.25%

Totals
Change from base Build 9062140401:	-0.9%
Covered Lines:	2650
Relevant Lines:	3415

---

💛 - Coveralls

[yebai]

Maybe add a depreciation message to these macros and inform users to look at alternative APIs?

[sunxd3]

Will do that and modify https://github.com/TuringLang/TuringTutorials/blob/master/tutorials/docs-12-using-turing-guide/using-turing-guide.jmd

[sunxd3]

@devmotion @torfjelde @yebai any suggestions on how to properly deprecate a macro?

[yebai]

@sunxd3 I am not aware of a way to depreciate a macro properly. One simple heuristic is to print an informational message and guide the user to the new APIs regardless of the input arguments to the macro.

[sunxd3]

Put back the macros, but now they return a warning command, not sure this is a good solution.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.95%. Comparing base (5b53be7) to head (41f5d47).
Report is 1 commits behind head on master.

❗ Current head 41f5d47 differs from pull request most recent head deafe64. Consider uploading reports for the commit deafe64 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
- Coverage   76.93%   75.95%   -0.98%     
==========================================
  Files          30       29       -1     
  Lines        3572     3435     -137     
==========================================
- Hits         2748     2609     -139     
- Misses        824      826       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yebai]

Looks good; maybe rename this file to depreciated.jl?

[torfjelde]

IMO if we can't deprecate properly, then either a) remove completely, or b) raise an error rather than @warn and do nothing (this will just warn and immediately throw an error somewhere unrelated in the code since now prob"..." doesn't do what it used to do).

[sunxd3]

I lean more to just delete them. It is not a core functionality that external code will likely rely on, so smaller chance or breaking behavior and surprises.

[yebai]

I lean more to just delete them. It is not a core functionality that external code will likely rely on, so smaller chance or breaking behavior and surprises.

I'm happy to delete these and add a release message to guide the users to new APIs.

[torfjelde]

When merging changes like this: a) make sure to update Project.toml, and b) make the breaking release afterwards and subsequently update the downstream projects that require it. Otherwise the next person who comes along and wants to contribute a simple bugfix will have to carry the full burden of this, which isn't great.

I would also gently remind people that we should generally let reviewers with "requested changes" reviews to respond before merging PRs.