Update FillArrays compat to 1.4.1 #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the final commit that fixed type inference broke ReverseDiff: TuringLang/DistributionsAD.jl#251 AD and broadcasting is.... annoying. |
Pull Request Test Coverage Report for Build 5519753582
💛 - Coveralls |
yebai
approved these changes
Jul 11, 2023
yebai
reviewed
Jul 11, 2023
| @testset "PDMatDistribution AD" begin | ||
| @model function wishart() | ||
| theta ~ Wishart(4, Matrix{Float64}(I, 4, 4)) | ||
| end | ||
| Turing.setadbackend(:tracker) | ||
| sample(wishart(), HMC(0.01, 1), 1000); | ||
| #Turing.setadbackend(:reversediff) | ||
| #sample(wishart(), HMC(0.01, 1), 1000); | ||
| Turing.setadbackend(:reversediff) |
There was a problem hiding this comment.
Do you know why ReverseDiff is working on these tests now?
There was a problem hiding this comment.
No, difficult to tell since it hasn't been tested for a long time.
There was a problem hiding this comment.
I also came across these not too long ago due to the changes we've been making in Bijectors. I think it might just be due to TuringLang/Bijectors.jl#246 which added these lines: https://github.com/TuringLang/Bijectors.jl/blob/9cd59070871cc7a29df0e401a24a08502241b230/ext/BijectorsReverseDiffExt.jl#L256-L259
|
This PR should wait for JuliaArrays/FillArrays.jl#278 and then the compat entry should be updated accordingly. |
devmotion
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2035 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 22 22
Lines 1444 1450 +6
======================================
- Misses 1444 1450 +6 ☔ View full report in Codecov by Sentry. |
yebai
added a commit
that referenced
this pull request
Jul 27, 2023
* CompatHelper: bump compat for Bijectors to 0.13, (keep existing compat) * Update Project.toml * Replacement for #2039 (#2040) * Fix testset for external samplers * Update abstractmcmc.jl * Update test/contrib/inference/abstractmcmc.jl Co-authored-by: Tor Erlend Fjelde <[email protected]> * Update test/contrib/inference/abstractmcmc.jl Co-authored-by: Tor Erlend Fjelde <[email protected]> * Update FillArrays compat to 1.4.1 (#2035) * Update FillArrays compat to 1.4.0 * Update test compat * Try to enable ReverseDiff tests * Update Project.toml * Update Project.toml * Bump version * Revert dependencies on FillArrays (#2042) * Update Project.toml * Update Project.toml * Fix redundant definition of `getstats` (#2044) * Fix redundant definition of `getstats` * Update Inference.jl * Revert "Update Inference.jl" This reverts commit e4f51c2. * Bump version --------- Co-authored-by: Hong Ge <[email protected]> * Transfer some test utility function into DynamicPPL (#2049) * Update OptimInterface.jl * Only run optimisation tests in numerical stage. * fix function lookup after moving functions --------- Co-authored-by: Xianda Sun <[email protected]> * Move Optim support to extension (#2051) * Move Optim support to extension * More imports * Update Project.toml --------- Co-authored-by: Hong Ge <[email protected]> --------- Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: haris organtzidis <[email protected]> Co-authored-by: Tor Erlend Fjelde <[email protected]> Co-authored-by: David Widmann <[email protected]> Co-authored-by: Xianda Sun <[email protected]> Co-authored-by: Cameron Pfiffer <[email protected]>
yebai
added a commit
that referenced
this pull request
Aug 16, 2023
* first draft * abstractcontext + tests * bug * externalsampler() in tests * Name Tupple problems * moving stuff to DynamicPPL RP * using new DynamicPPL PR * mistakenly removed line * specific constructors * no StaticMH RWMH * Bump bijectors compat (#2052) * CompatHelper: bump compat for Bijectors to 0.13, (keep existing compat) * Update Project.toml * Replacement for #2039 (#2040) * Fix testset for external samplers * Update abstractmcmc.jl * Update test/contrib/inference/abstractmcmc.jl Co-authored-by: Tor Erlend Fjelde <[email protected]> * Update test/contrib/inference/abstractmcmc.jl Co-authored-by: Tor Erlend Fjelde <[email protected]> * Update FillArrays compat to 1.4.1 (#2035) * Update FillArrays compat to 1.4.0 * Update test compat * Try to enable ReverseDiff tests * Update Project.toml * Update Project.toml * Bump version * Revert dependencies on FillArrays (#2042) * Update Project.toml * Update Project.toml * Fix redundant definition of `getstats` (#2044) * Fix redundant definition of `getstats` * Update Inference.jl * Revert "Update Inference.jl" This reverts commit e4f51c2. * Bump version --------- Co-authored-by: Hong Ge <[email protected]> * Transfer some test utility function into DynamicPPL (#2049) * Update OptimInterface.jl * Only run optimisation tests in numerical stage. * fix function lookup after moving functions --------- Co-authored-by: Xianda Sun <[email protected]> * Move Optim support to extension (#2051) * Move Optim support to extension * More imports * Update Project.toml --------- Co-authored-by: Hong Ge <[email protected]> --------- Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: haris organtzidis <[email protected]> Co-authored-by: Tor Erlend Fjelde <[email protected]> Co-authored-by: David Widmann <[email protected]> Co-authored-by: Xianda Sun <[email protected]> Co-authored-by: Cameron Pfiffer <[email protected]> * Bugfixes. * Add TODO. * Update mh.jl * Update Inference.jl * Removed obsolete exports. * removed unnecessary import of extract_priors * added missing ) in MH tests * fixed incorrect referneces to AdvancedMH in tests * improve ESLogDensityFunction * remove hardcoding of SimpleVarInfo * added fixme comment * minor style changes * fixed issues with MH with RandomWalkProposal being used as an external sampler * fixed accidental typo * move definitions of unflatten for NamedTuple * improved TODO * Update Project.toml --------- Co-authored-by: Hong Ge <[email protected]> Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: haris organtzidis <[email protected]> Co-authored-by: Tor Erlend Fjelde <[email protected]> Co-authored-by: David Widmann <[email protected]> Co-authored-by: Xianda Sun <[email protected]> Co-authored-by: Cameron Pfiffer <[email protected]> Co-authored-by: Hong Ge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaArrays/FillArrays.jl#273 (supposedly) fixes the issues with FillArrays > 1.0.0.
Fixes #2017 Fixes #2029
Edit: Needs JuliaArrays/FillArrays.jl#278 as well.