Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting VI files #2263

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Formatting VI files #2263

merged 2 commits into from
Jun 11, 2024

Conversation

yebai
Copy link
Member

@yebai yebai commented Jun 10, 2024

There is no real change here -- only formatting a few VI source files.

src/variational/advi.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@@ -1,5 +1,6 @@
style="blue"
format_markdown = true
import_to_using = false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willtebbutt is there a good reason for preferring using SomePkg: SomePkg over import SomePkg?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong views on this -- maybe import is preferable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like slightly prefer import here.

@yebai yebai requested a review from willtebbutt June 10, 2024 19:20
@yebai yebai merged commit 22028aa into master Jun 11, 2024
57 checks passed
@yebai yebai deleted the hg/format-vi branch June 11, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants