Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new style kwarg constructor for AutoReverseDiff #2273

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Jun 25, 2024

ADTypes v1.5 changes the AutoReverseDiff constructor (SciML/ADTypes.jl#65), which is causing our CI to fail. This PR starts using the new style constructor. The new style was valid before too, so we remain compatible with older ADTypes versions.

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mhauru, for the fix!

@mhauru mhauru merged commit a0db647 into master Jun 25, 2024
57 checks passed
@mhauru mhauru deleted the mhauru/adtypes-kw-constructor branch June 25, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants