Fix some bug in eval_num from #740
#770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yebai
added a commit
that referenced
this pull request
May 6, 2019
commit beda95d Author: Kai Xu <[email protected]> Date: Mon May 6 14:09:50 2019 +0100 Replace HMC related codes using AHMC (#739) * integrate AHMC * make functions safe and add AHMC in REQUIRE * implement experimental interface for ANUTS * fix init_theta masking * update to AHMC's new interface * fix type constraint * replace find_good_eps * replace low-level HMC functions * remove old comments * remove rev and log funcs * remove returned value from gen_grad_func * replace adapation with AHMC code * remove adapation code * remove implict sampler constructors * use integrated sample() if AHMC if possible * delete ahmc.jl * add version to AHMC * make AHMC version master * revert version of AHMC * rename binding AdvancedHMC -> AHMC * add AHMC#master to deps * improve typing of mh_accept * merge hmcda.jl and nuts.jl into hmc.jl * replace conditions with multiple dispatch * not storing adapt_conf in spl.info * relax Sampler to AbstractSampler * use AHMC.transition instead of copied version * tweak comments * mvoe hmc_core.jl into hmc.jl * clean up * clean up hmc.jl * bugfix * Remove some redundant docs. * Some formating fixes - no functionality change. * epsilon ==> ϵ. * tau ==> n_leapfrog. * add type for metricT * remove redudant .logp * fix typo in comment * unroll first and rest iterations for steps * Rename all: epsilon ==> ϵ * Remove global STAN_DEFAULT_ADAPT_CONF and related types. * Disable stan interface temporarily before fixing #746 * Ensure h.metric has the same dim as θ. * Bugfix for using `step` in Gibbs. * Merge SGLD into SGHMC - no functionality change. * Add default metric type to SGLD and SGHMC. * Merge test/SGLD into test/SGHMC - no functionality change. commit 502027b Author: Mohamed Tarek <[email protected]> Date: Sun Apr 28 19:39:57 2019 +1000 fix some bug in `eval_num` from #740 (#770)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug that crept in from #660 in #740.