Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] 자연스러운 스크롤을 위해 Navigation 이 스크롤 상단에 있을 때 absolute 가 되지 않도록 수정 #256

Merged
merged 1 commit into from
Sep 11, 2022
Merged

[fix] 자연스러운 스크롤을 위해 Navigation 이 스크롤 상단에 있을 때 absolute 가 되지 않도록 수정 #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/client/src/components/molecule/Navigation.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@
<!-- fly animation 시 header 아래로 nav 가 expand 되도록 element 의 순서를 바꾸고 `flex-col-reverse` 를 적용 -->
<aside class='{clazz} flex flex-col-reverse justify-end max-h-screen z-50 overflow-y-auto'
transition:fly={{ y: -100, duration: 500 }}
class:absolute={collapsable && isOnTop}
class:fixed={collapsable && !isOnTop}>
class:fixed={collapsable}>
{#if !collapsable || !collapsed}
<nav transition:fly={{ y: -100, duration: 500 }}
class='{navClass} px-6 md:px-10 flex flex-col bg-gray-200 grow overflow-y-auto shadow-md'
Expand Down