Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #1

Merged
merged 1 commit into from
Apr 22, 2018
Merged

Update CONTRIBUTING.md #1

merged 1 commit into from
Apr 22, 2018

Conversation

TylerSanford
Copy link
Owner

Description

Line 44 of CONTRIBUTING.md the command is not highlighting git clone which is a part of the command block.

Also the command git clone [email protected]:<your-username>/gatsby.git doesn't work for me.

Proposed new command line of git clone https://github.com/<your-username>/gatsby.git which does work for me every time.

Steps to reproduce

By viewing the doc CONTRIBUTING.md line 44, also by attempting the command as described: git clone [email protected]:<your-username>/gatsby.git

Expected result

Docs should have the whole command highlighted to eliminate confusion. Also command should properly clone the fork.

Actual result

`[email protected]:~/Desktop$ git clone [email protected]:tylersanford/hello-world.git
Cloning into 'hello-world'...
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.`

Environment

  • Gatsby version (npm list gatsby): N/A - Doc change
  • gatsby-cli version (gatsby --version): N/A - Doc change
  • Node.js version: node -v: v9.7.1
  • Operating System: macOS High Sierra 10.13.4

File contents (if changed):

CONTRIBUTION.md:
* Clone your fork: git clone https://github.com//gatsby.git``

@TylerSanford TylerSanford merged commit 20f831d into master Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant