-
-
Notifications
You must be signed in to change notification settings - Fork 13
Semantic Highlighting #32
Comments
Hi @cdietrich for example if you add it here: The wrapper is then started with the full config object. If that does not work, please let me know. Thanks |
@kaisalmen i got it running with the vscode config |
@cdietrich Although we happened to write the Langium docs targeting the classic config, we utilize both in our own implementations (ex. the showcase statemachine example uses the VSCode config, while others use the classic config). Going with the VSCode config is a perfectly fine choice, and we should support this in documentation as well; we just need to get to get around to adding it in. |
@cdietrich thanks for your feedback. The semantic highlighting should work when using the classic configuration. I need to investigate. |
@cdietrich yes, it is a bug in the initialization. The configured user parameters where not taken into account. They were initialized always empty |
I will fix this together with in #31 |
thx. i found this workaround
|
@cdietrich This is fixed with #31. The configuration changed again, sorry, but now you configure the respective editor application at one place and either the classic or the vscode-api one, see the two examples: |
cool. works smooth now. thx |
@kaisalmen should it be possible to use |
Yes, as long as you don't enable theme and textmate service, see also this explanation: |
yes but this works neither (it crashes with)
see https://github.com/cdietrich/hello-world-sem-high |
Thank you, I will investigate. My understanding is that this should work. |
@cdietrich there is now an example available (moved over from I will continue the investigation. This new examples shows how to achieve the same editor behavior in both modes (almost 😅 ). |
@cdietrich there is a workaround now available in the Langium grammar example: Full fix for the wrapper comes tomorrow. |
@kaisalmen did you change something again in mer 2.2.0 / mew 3.2.0? |
It was working fine. Justed checked it with this: Did you adjust the service loading? See also: |
@cdietrich but I found another issue that I overlook/broke again: Waiting for extension loading is broken. Will release a 3.2.1 soon. |
the funny thing is: it works in wrapper but does not work in react. |
classic or vscodeApi mode? |
we use
|
Easiest approach is to use this config from https://github.com/TypeFox/monaco-components/blob/main/packages/examples/src/langium/config/wrapperLangiumClassic.ts and use it here: |
You can just plug the same config into the react component |
problem is we use old node, so we also need to cross compile etc .... :( |
ok got it running. problem was on our side |
@kaisalmen tried so create a simplified example with vite assert.js:22 Uncaught Error: Assertion failed (There is already an extension with this id) any idea? solved by deduping monaco and vscode |
Hello, I'm facing the same issue as you ("(There is already an extension with this id") Can you please explain what you mean by "deduping monaco and vscode" Thanks! |
Updated |
Hi, is there a way to enable semantic highlighting in 2.x
(I am using the classic variant)
Somehow i don’t find a way to properly pass
“semanticHighlighting.enabled”: true
Down to Monaco anymore
(Was working before in 1.6 cdietrich/langium-inject-files-webworker@138d71e)
The text was updated successfully, but these errors were encountered: