This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
semantic highlighting works with classic editor #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
montymxb
reviewed
Sep 18, 2023
|
Thank you. This is good to go from my side now. |
montymxb
approved these changes
Sep 19, 2023
|
@kaisalmen is this already part of |
|
@cdietrich yes it is. This PR is in and 47 (status from yesterday) and 48 are in. |
|
hmm somehow i still get the same error in my example. need to digg. problem found: is working now |
|
@cdietrich Superb! Btw, the langium example now allows you to launch the editor in both modes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapper always uses the configuration service from
monaco-vscode-apiwhat basically makesupdateUserConfigurationmandatory for configuration updates after start.In classic mode
editorOptionsthat are editor specific work, but things likesemanticHighlightingrequires the user configuration update due to the activation of the vscode configuration service. This PR takes thesemanticHighlightingfrom theeditorOptionsand applies them the the userConfiguration. This prevents to run into the same problem as #32 .This PR moves
userConfigurationtoEditorAppBaseConfigwhich makes it available in both classic mode and vscodeApi mode. It is generally advised to use this mean to configure the app, but we leave the monaco-editor options in for BW-compatibility reasons.Overall aim to allow monarch + semanticHighlighting is achieved.