This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
htmlElement is no longer part of UserConfig. Must be passed at start #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisalmen
force-pushed
the
direct-html-element
branch
from
adaaeff
to
f2ea196
Compare
kaisalmen
changed the title
kaisalmen
force-pushed
the
direct-html-element
branch
from
f2ea196
to
1c0a129
Compare
kaisalmen
force-pushed
the
direct-html-element
branch
from
1c0a129
to
ffe5bee
Compare
approved!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alignment with how monaco-editor is started. The HTMLElement must now be passed at
wrapper.start. It is no longer part of the UserConfig.It also removes the need to pass the html element twice to the react component.