Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to monaco 0.18.x #176

Closed
akosyakov opened this issue Sep 9, 2019 · 8 comments · Fixed by #178
Closed

migrate to monaco 0.18.x #176

akosyakov opened this issue Sep 9, 2019 · 8 comments · Fixed by #178
Labels
help wanted pinned

Comments

@akosyakov
Copy link
Contributor

No description provided.

@gitpod-io-legacy-app
Copy link

Open in Gitpod - starts a development workspace with a preconfigured issue branch and opens it in a browser IDE.

@akosyakov akosyakov changed the title migrate to monaco 0.18.0 migrate to monaco 0.18.1 Sep 20, 2019
@akosyakov akosyakov changed the title migrate to monaco 0.18.1 migrate to monaco 0.18.x Sep 20, 2019
@akosyakov akosyakov mentioned this issue Sep 20, 2019
Closed
@PHameete
Copy link
Contributor

What needs to be done for this upgrade?

I'm unclear how the LanguageClient exactly connects to the Monaco editor. Is this just a matter of updating MonacoToProtocolConverter and ProtocolToMonacoConverter to correspond with https://github.com/microsoft/monaco-editor/blob/master/monaco.d.ts ?

@akosyakov
Copy link
Contributor Author

  • Bump up the version
  • fix all compilation errors
  • try out examples and make sure that they work

then ping me to publish the dev version for a PR that it can be tested in downstreams

@PHameete
Copy link
Contributor

PHameete commented Oct 1, 2019

I'll try to open a PR today.

@PHameete PHameete mentioned this issue Oct 1, 2019
Merged
@PHameete
Copy link
Contributor

PHameete commented Oct 1, 2019

Its already done actually :-) please take a look when you can. I've tried the examples and they are working.

@rcjsuen
Copy link
Collaborator

rcjsuen commented Dec 30, 2019

Looks like Monaco 0.19.0 has been released. 🤔

@PHameete
Copy link
Contributor

@rcjsuen lets get this merged first, then we can look at 0.19.0 :-)

Hopefully @akosyakov can find some time for reviewing/merging.

@zerocewl
Copy link

any news here @akosyakov ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted pinned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Monaco to 0.18.1
4 participants
@akosyakov @PHameete @zerocewl @rcjsuen