Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Monaco 0.18.1 #6223

Closed
akosyakov opened this issue Sep 20, 2019 · 5 comments
Closed

upgrade to Monaco 0.18.1 #6223

akosyakov opened this issue Sep 20, 2019 · 5 comments
Labels
help wanted issues meant to be picked up, require help monaco issues related to monaco

Comments

@akosyakov
Copy link
Member

In order to solve scrolling issues on Firefox: #5901 (comment)

First we have to do: TypeFox/monaco-languageclient#176

cc @danidoedel @marechal-p You are welcomed to look into it!

@akosyakov akosyakov added help wanted issues meant to be picked up, require help monaco issues related to monaco labels Sep 20, 2019
@akosyakov
Copy link
Member Author

@svenefftinge or should I do it once more?

@akosyakov
Copy link
Member Author

During migration please move or create a new fork of vscode under theia-ide org and publish not tree shaken distribution under @theia npm scope.

@BroKun
Copy link
Member

BroKun commented Oct 31, 2019

@akosyakov The latest version of @typefox/monaco-editor-core 0.18.0-next.1 has problems with nls related files. The configuration files for all national languages ​​are in English. Please check it before the next release.

@akosyakov
Copy link
Member Author

@BroKun thanks for the notice! Have you checked whether it is an issue with https://www.npmjs.com/package/monaco-editor-core as well? It would be good to open an issue in the upstream then.

@BroKun
Copy link
Member

BroKun commented Oct 31, 2019

@akosyakov Their recent release of 0.18.0 and 0.18.1 are fine. I don't know what happened here, so I am looking for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted issues meant to be picked up, require help monaco issues related to monaco
Projects
None yet
Development

No branches or pull requests

2 participants