Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert addition of package.json "exports" because it is a breaking ch… #1027

Merged
merged 1 commit into from
May 3, 2020

Conversation

cspotcode
Copy link
Collaborator

…ange and requires more thought

Fixes #1026.

I would still like to merge #1026 eventually, but for an immediate fix, this seems the safest.

Copy link

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is obviously also good for me! :)

@cspotcode
Copy link
Collaborator Author

@addaleax I appreciate the very quick bug report and PR! The medium post you linked mentioned issues with importing ./package.json and I think I need more time to read about the implications. But then I'll definitely come back to #1026 and get it merged.

@cspotcode cspotcode merged commit 9fb567a into master May 3, 2020
@addaleax
Copy link

addaleax commented May 3, 2020

@cspotcode #1026 doesn’t really apply as a patch anymore, so I’ve deleted the branch, but yeah, if you add an "exports": key, making sure that all possible entry points are listed should help a lot :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.709% when pulling 2bee85e on ab/revert-package-exports into 6fc4298 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.709% when pulling 2bee85e on ab/revert-package-exports into 6fc4298 on master.

@cspotcode cspotcode deleted the ab/revert-package-exports branch May 9, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants