Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing tests #1035

Merged
merged 2 commits into from
May 10, 2020
Merged

fix failing tests #1035

merged 2 commits into from
May 10, 2020

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented May 10, 2020

node 6 / npm doesn't respect package-lock.json so it sometimes installs newer versions of deps than the other tests. This caused a test failure.

Fix is to manually upgrade the dep, commit changes to package-lock.json, then fix the resulting linter failure

I also removed the ^ from 2 versions so that even node 6 tests will install exactly those version numbers.

@cspotcode cspotcode changed the title fix fix failing tests May 10, 2020
@coveralls
Copy link

coveralls commented May 10, 2020

Coverage Status

Coverage remained the same at 80.709% when pulling 634f23b on ab/fix-failing-tests2 into c1ae9a0 on master.

@cspotcode cspotcode merged commit a335834 into master May 10, 2020
@cspotcode cspotcode deleted the ab/fix-failing-tests2 branch May 17, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants