Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS 5.0 Supporting Multiple Configuration Files in extends #1958

Merged
merged 7 commits into from
Feb 13, 2023

Conversation

cspotcode
Copy link
Collaborator

Fixes #1954

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1958 (679faa3) into main (ba741fa) will increase coverage by 0.19%.
The diff coverage is 78.94%.

Impacted Files Coverage Δ
src/configuration.ts 86.71% <78.94%> (+0.42%) ⬆️
src/child/spawn-child.ts 81.25% <0.00%> (-6.25%) ⬇️
src/bin.ts 90.05% <0.00%> (+2.76%) ⬆️

@WoodyWoodsta
Copy link

👀 With TS 5 now released, when can we expect to have this be published?

@cspotcode
Copy link
Collaborator Author

No set time. I recommend installing from git in the meantime.

#1977

@WoodyWoodsta
Copy link

WoodyWoodsta commented Mar 28, 2023

Unfortunately I'm here indirectly from conventional-changelog/commitlint 😄 so a git resolution won't work as this repo doesn't contain build outputs.

But in the meantime I'll fork and publish a built version of master to our private registry.

Is there a reason this is on hold? Are there more TS 5 updates that need to be made?

@cspotcode
Copy link
Collaborator Author

To be sure we're on the same page, you're in an environment where the prepare script will not run for a git dep? But yeah, you can go with any workflow where you npm pack and then put that tarball somewhere and use it.

@WoodyWoodsta
Copy link

In my environment, ts-node is a transitive dependency and we use yarn as a package manager. I believe yarn > 1 doesn't support prepare: yarnpkg/berry#2305

@cspotcode
Copy link
Collaborator Author

Thanks for bringing that to my attention. I've switched us over to using prepack instead #1979

@WoodyWoodsta
Copy link

No problem - thank you for making that change!

@DreamOfIce
Copy link

Is there anything preventing us from releasing a patch version?
Installing from git is slow and often reports errors

@smorimoto
Copy link

Thank you so much for this changes! I think it would be possible to backport only this changes on top of the previous release for a point release, but would that be difficult?

@slavafomin
Copy link

Hello! Thank you for your hard work, however, what's blocking this patch from being released? It's been half a year already and a lot of people are still having trouble with this issue.

@roydukkey
Copy link

If your still waiting for this release, you might look into tsx.

@slavafomin
Copy link

If your still waiting for this release, you might look into tsx.

Wow, it looks pretty cool. Thank you for mentioning it. I will definitely give it a try.

@Elyahou
Copy link

Elyahou commented Sep 7, 2023

Any news about the release ?

@FreePhoenix888
Copy link

I am going to use typescript and node instead of using ts-node because this takes so long

@mrkjdy
Copy link

mrkjdy commented Feb 2, 2024

@blakeembrey Can a patch version be released to fix this problem as well? I was hoping that this was available in 10.9.2, but it's still not.

giseburt added a commit to giseburt/projen that referenced this pull request Feb 28, 2024
mergify bot pushed a commit to projen/projen that referenced this pull request Feb 28, 2024
#3409)

This is adding support for `compilerOptions` used [in the wild](https://github.com/tsconfig/bases/blob/main/bases/strictest.json) and escape hatches had to be used.

This was found when applying [@tsconfig/strictest](https://github.com/tsconfig/bases?tab=readme-ov-file#strictest-tsconfigjson) and working around TypeStrong/ts-node#1958 (merged, but not yet released, a year later)

No issue was created, and no tests were added. This is merely a pass-thru to tsconfig (like the existing options above them in the code).

---
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
enisdenjo added a commit to ardatan/graphql-mesh that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for TS 5.0 "extends" array
9 participants