-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New UI #121
New UI #121
Conversation
fef562e
to
fae0424
Compare
5297338
to
2aa60f3
Compare
d8ee71c
to
9c3a772
Compare
66950f9
to
f38bb8a
Compare
@niels9001 🔝 Look what I made! 😁 |
Keyboard accessible: includes #79 |
I will take a look at this, later this week or next week most likely. |
Not that anyone asked, but thought I'd share my aesthetic 2 cents. fwiw I personally really do not like Mica, so I'm hoping this PR (if it's used ultimately, and in general with this project otherwise) doesn't force it. I actually prefer the un-colored (sorta light grey/white-ish in light mode, dark grey in dark) background that some windows UI surfaces have, over Mica, with Acrylic above either. All three options might be nice actually if users want it and it's not hard to implement (meaning, add the uncolored one, as there's already Mica/Acrylic). Apart from colors tho, I like everything else about your version. The consistency with the rest of Win11's design language really makes Hurl feel like a part of windows, which feels appropriate given it's a power user utility app - one of my favorite things about modern third party mac apps is how well they gel with the rest of the OS. This version feels a lot like, say, the "Open with..." dialog, or even the start menu, etc. The only thing would be that I'd expect (going by Start Menu) that context menus and tooltips would have drop shadows. And something about the corner rounding and padding of the tooltip seems off. |
And if you guys were willing, I wanted to derail this thread for second to ask how I can learn more about the various different ways of making windows apps, eg what is the difference/tradeoffs between WPF, WinUI, etc? |
There was a recent Build session about that: https://youtu.be/ZjaL3pL-OuM?si=ZCPdRGEDB6JcQ6X6 |
Hi @riotrah, thank you for your message! Yeah, the background issue feels like a personal opinion. I don't mind it. But, of course, you may have yours 🙂 I will leave it to @U-C-S if he wants to use it or something else. Actually, with the current version of WPF-UI, there is a bug where, after a while, the mica effect fails. Even on Windows 11. So, you might just like that, haha! Thank you so much for the compliment! I'm really proud of it! 😇 I even have a few more (small) things waiting for a next PR. About the little UI bugs you mention: that's a WPF-UI issue. From what I can tell it is "just" a third-party framework and personally I am not a fan of that. I would rather use either WinUI c.q. Microsoft WPF. But that's also a choice @U-C-S has to make. And it requires quite a big re-write. |
I really want to, But it's so hard/confusing to get a unpackaged app running properly and reliably, and the install sizes are huge (like ranging from 40MB to 180MB). Wouldn't be much Big rewrite either, I have done it thrice (including a UWP port) already at this point and gave up during publishing. But the preview or upcoming updates for both WPF and WinAppSDK/WinUI looks really promising. Looking into your PR currently @Jay-o-Way |
Tried it out locally. I like couple of ideas here like the bottom bar where you put the Rules, settings btns... I personally do not like the way the looks of WinUI TextBox, But I want to do something like current Edit URL button which onClick gets swapped with TextBox control, which I feel is best of both our ideas. What do you think ? I will keep updating this comment as I use it. |
Is there something specific? This control has a lot of important benefits with accessibility: Tabstop, in-place-editing, built-in "clear" button and context-menu, screen reader support... People that use non-standard input devices really need this. Users want things to be as fast and easy as possible. Maybe I could set the default background to Transparent - to make it even more subtle. That'll leave the hover and focus colors intact. Sneak preview |
This comment has been minimized.
This comment has been minimized.
It looks much better actually.
Additionally, continue with my thoughts on changes you made,
I want to continue further (including about the change I made recently: 13e3d4d#commitcomment-143173677), but Maybe at this point, it would be a better idea, to have it in a new discussion conversation instead because it feels UI design discussions are spread out in lots of places.
|
@U-C-S I Updated TextBox and Add button. I know the Textbox is an open discussion but is there anything actually blocking this? Thanks. |
Sorry, didn't notice this comment
PR tweaks lot of things, which is fine, but there are changes I don't want or have a prior focused discussion... which would make a quite a list. So probably I think, the better idea would be breaking this PR into multiple small PRs where I have some I can merge straight away (like the code refactor stuff etc...), some I don't like to (removal of 2 app visual settings etc...) and some with discussion. honestly I am not certain what's the better thing to do for a PR which changes lot of things. or Should I review the PR and just point out things I wouldn't want ? |
Okay @U-C-S I hear you. I had a few extra ideas I can use on the new PRs. I just worry that multiple PRs will create merge conflicts between them, causing extra work when one is merged. |
Yeah you are right. But don't know any alternative way we can do this, but more focused PRs are very sensible to keep track off for me as a maintainer.
|
I understand. (Not the first time I got that feedback 🫣) |
App-wide
xmlns:wpfui=
everywhere - no moreui=
Browser window
Important
Commented keybindings and number-watching keys
Ruleset Manager
Ruleset editor window
Timed browser