Getting 3D visualizations working again

[trevorcampbell]

• Closes Add plotly to the docker image #127
• Closes 3D Plot in Chapter 5 not rendering #83

One potential issue: I see

/home/jovyan/source/classification1.md:786: WARNING: skipping unknown output mime type: application/vnd.plotly.v1+json [mystnb.unknown_mime_type]

@joelostblom if you want you can make similar viz adjustments to these new 3d figs that you made previously

In order to test this, just run the docker container interactively (instead of using build_html.sh), install plotly, and run jupyter-book build source.

NB: we will almost certainly have to have a build flag check for the PDF build and use a stored png version of these instead, but we can cross that bridge when we get to it

[trevorcampbell]

Let's not merge this until we merge #241 , so that we can use this PR as a test run for that new workflow

[joelostblom]

Nicely done, these changes look great and show up as expected in the rendered book!

Based on jupyter-book/jupyter-book#1950, it seems like that warning should not be an issue and can be either suppressed or the plotly rendering engine can be switch to an iframe jupyter-book/jupyter-book#2041

I found different syntax for how to enter the container interactively, so for reference this is what I used docker container run -it --rm -v $(pwd):/home/jovyan ubcdsci/py-intro-to-ds:20230831171718ddf538 /bin/bash

if you want you can make similar viz adjustments to these new 3d figs that you made previously

Hmm,I am not sure which changes you are referring to here.

[trevorcampbell]

Hmm,I am not sure which changes you are referring to here.

Just the various syntax formatting stuff you did. It's really unimportant, because all the code is hidden anyway.

[trevorcampbell]

I found different syntax for how to enter the container interactively, so for reference this is what I used docker container run -it --rm -v $(pwd):/home/jovyan ubcdsci/py-intro-to-ds:20230831171718ddf538 /bin/bash

No need for container -- you can just do:

 docker run -it --rm -v $(pwd):/home/jovyan ubcdsci/py-intro-to-ds:20230831171718ddf538 /bin/bash

[trevorcampbell]

I'm going to close and re-open this to try to trigger the new workflow from #241

[joelostblom]

Just the various syntax formatting stuff you did. It's really unimportant, because all the code is hidden anyway.

Ah I see, I don't think that applies here since it was mostly altair-specific.

[trevorcampbell]

New github actions workflow is working properly, but it will re-build the image on every change to the PR. I've now edited the workflow in e3701aa so that it should only run when the Dockerfile itself is changed, but I'm going to push an empty commit here to test it.

[trevorcampbell]

OK, I've got the new workflow working properly. I force-pushed removal of a bunch of garbage commits while debugging, and I'm merging this now.