Skip to content

Commit

Permalink
Drop 3.9 support (#360)
Browse files Browse the repository at this point in the history
Following the recent change on GitHub Actions
actions/setup-python#850 our tests are
currently failing #359.

Previously we were following
[NEP29](https://numpy.org/neps/nep-0029-deprecation_policy.html) which
is why we never supported `3.8`. My suggestion is to drop `3.9` which
means nothing else has to change.

The alternative is to do @dstansby's
[suggestion](#359 (comment)),
but I think this is low-key complicated when involving our `tox` setup
too. Personally, I don't think it's worth it, and we should fix the
tests ASAP.
  • Loading branch information
paddyroddy authored May 17, 2024
1 parent 448fd25 commit fc502d6
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
1 change: 0 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
- ubuntu-latest
- windows-latest
python-version:
- "3.9"
- "3.10"
- "3.11"
- "3.12"
Expand Down
4 changes: 2 additions & 2 deletions cookiecutter.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"initialise_git_repository": true,
"deploy_docs_to_github_pages": false,
"github_username": "{{cookiecutter.author_given_names.lower().replace(' ', '-')}}-{{cookiecutter.author_family_names.lower().replace(' ', '-')}}",
"min_python_version": ["3.9", "3.10", "3.11", "3.12"],
"max_python_version": ["3.12", "3.11", "3.10", "3.9"],
"min_python_version": ["3.10", "3.11", "3.12"],
"max_python_version": ["3.12", "3.11", "3.10"],
"license": ["MIT", "BSD-3", "GPL-3.0"],
"funder": "JBFC: The Joe Bloggs Funding Council",
"__prompts__": {
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ overrides."tool.coverage.paths.source".inline_arrays = false
legacy_tox_ini = """
[gh-actions]
python =
3.9: py39
3.10: py310
3.11: py311
3.12: py312
Expand Down

0 comments on commit fc502d6

Please sign in to comment.