A temporary directory utility function for file I/O tests. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcunliffe
added
testing
samcunliffe
commented
Nov 17, 2022
| @@ -5,12 +5,15 @@ | |||
| #pragma once | |||
|
|
|||
| #include <complex> | |||
| #include <filesystem> | |||
| #include <random> | |||
| #include <string> | |||
|
|
|||
| namespace tdms_tests { | |||
There was a problem hiding this comment.
Namespaces shouldn't be indented according to Google.
willGraham01
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tmp directory function which was developed for #181, but seems like it's useful already.
@alessandrofelder mentioned that there might be a cleaner(?) way to do this in CMake (which I haven't investigated). But mine is now only a few lines of C++ from the
stdlibrary. So hopefully not too clunky.The
*_utils.hfile has a messy diff because I changed the indentation. I'd recommend turning whitespace off (if you haven't already done so).