"Fix" M2 Mac TDFieldExporter2D problem.
#254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand how the previous c_str() call could be any different.
For consistency and sanity. Use std::string in the TDFieldExporter2D. Check std::string equality early and convert to char array only for writing the file.
samcunliffe
added
the
review required
willGraham01
approved these changes
Mar 10, 2023
Co-authored-by: Will Graham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3b0fcb3 fixes the problem with exporting the fields to a non-existent directory. And since I've got the context in my head, I replaced
char* folder_namein theTDFieldExporter2Dto anstd::stringand did some sanity refactoring in 9fbe3e7.Probably related to #211. Superficially fixes #255 (I retrospectively created a bug report) and fixes #129 (I forgot that we'd seen this before and it disappeared).