Pairdev: writing data to H5::Groups.
#294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcunliffe
force-pushed
the
181-pairdev-write-dataset-to-group
branch
from
9fa3b71
to
986bd02
Compare
samcunliffe
commented
May 13, 2023
| * @brief Convert from C++ datatype T to a H5::PredType for HDF5 write out. | ||
| * | ||
| * TODO: Doesn't support complex doubles. Might need a compount datatype. | ||
| * Investigate how to read complex doubles first. |
There was a problem hiding this comment.
We should probably throw an std::logic_error("Not implemented") if we try with T as a complex double.
Also compount → compound (might me my typo).
samcunliffe
commented
May 13, 2023
| * @brief Checks if `name` exists in this file. | ||
| * | ||
| * @details Just wraps some ugly H5Lexists call from the C-API. | ||
| * TODO: does this work if given 'group/subgroup' ? |
There was a problem hiding this comment.
TODO: can we just use file_->nameExists?
willGraham01
force-pushed
the
181-hdf5-io-pairdev
branch
from
05ef9fc
to
30899d5
Compare
willGraham01
force-pushed
the
181-pairdev-write-dataset-to-group
branch
from
02d04a8
to
a8d6b56
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## 181-hdf5-io-pairdev #294 +/- ##
==================================================
- Coverage 48% 48% -0%
==================================================
Files 72 72
Lines 7931 7922 -9
==================================================
- Hits 3817 3802 -15
- Misses 4114 4120 +6
☔ View full report in Codecov by Sentry. |
Co-authored-by: willGraham01 <[email protected]>
Any file object. Co-authored-by: willGraham01 <[email protected]>
Some WIP typedef is incomplete and we've hardcoded H5::PredType::Double. Need to convert from native C++. Co-authored-by: Will Graham <[email protected]>
Convert between native C++ datatypes and H5::PredTypes. Needs some unit testing! Co-authored-by: willGraham01 <[email protected]>
* Update catch2 (#275) * Update catch2. v3.3 has some nice features. Including a SKIP() macro. 💙 * Skip the segfault test. * SKIP unit tests if sample data not generated. Since we're introducing a bit of complexity into the unit-testing framework, at least we should skip the tests (developer quality of life) with a nice warning explaining why. * Skip function. 2 lines → 1. And gets rid of another global. Co-authored-by: willGraham01 <[email protected]> * Revert to explicitly skipping the broken test. --------- Co-authored-by: willGraham01 <[email protected]>
willGraham01
force-pushed
the
181-pairdev-write-dataset-to-group
branch
from
a8d6b56
to
f3a8671
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.