First pass adding basic prerequisites #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
===================================
Coverage 26% 26%
===================================
Files 83 83
Lines 3687 3687
===================================
Hits 949 949
Misses 2738 2738 ☔ View full report in Codecov by Sentry. |
Very basic preliminaries. CMake, Windows SDK, Xcode etc.
* V. minor tweak to language. * Add OS logos from EgoistDeveloper/operating-system-logos * Split MacOS into its own thing.
samcunliffe
force-pushed
the
292-pedagogical-prerequisites
branch
from
e55f9b6
to
f34f406
Compare
2 tasks
samcunliffe
added
documentation
willGraham01
approved these changes
May 26, 2023
Co-authored-by: Will Graham <[email protected]>
samcunliffe
commented
May 26, 2023
samcunliffe
commented
May 26, 2023
samcunliffe
commented
May 26, 2023
| PS> conda list fftw # assuming you installed via conda | ||
| PS> which.exe MATLAB | ||
| ``` | ||
| Which should return something like `C:\Program Files (x86)\MATLAB\R20XXx\bin\matlab` and maybe `C:\ProgramData\envs\base\bin`. |
There was a problem hiding this comment.
Suggested change
| Which should return something like `C:\Program Files (x86)\MATLAB\R20XXx\bin\matlab` and maybe `C:\ProgramData\envs\base\bin`. | |
| Which should return something like `C:\Program Files (x86)\MATLAB\R20XXx\bin\` for MATLAB, and `C:\ProgramData\anaconda\envs\base\Library\lib` or `C:\Users\<your username>\anaconda\Library\lib\cmake\fftw3`. |
samcunliffe
commented
May 26, 2023
samcunliffe
commented
May 26, 2023
| </details> | ||
|
|
||
| <details> | ||
| <summary><img src="https://github.com/EgoistDeveloper/operating-system-logos/blob/master/src/24x24/WIN.png"/> Windows prerequisite setup</summary> |
There was a problem hiding this comment.
Tagging @edggjames FYI... 👇
|
@willGraham01 sorry for the noise. I've just made a (final??!) pass. Would you mind re-checking everything for me please? |
| <details> | ||
| <summary><img src="https://github.com/EgoistDeveloper/operating-system-logos/blob/master/src/24x24/WIN.png"/> Windows prerequisite setup</summary> | ||
|
|
||
| TDMS was developed on, and has been extensively tested on linux. |
There was a problem hiding this comment.
Suggested change
| TDMS was developed on, and has been extensively tested on linux. | |
| TDMS was developed - and extensively tested - on linux. |
|
|
||
| Assuming you don't already have them, you'll need to download and install: | ||
|
|
||
| <!-- * HDF5 --> |
There was a problem hiding this comment.
Suggested change
| <!-- * HDF5 --> | |
| <!-- * TODO: When HDF5 comes in --> |
There was a problem hiding this comment.
Huh. I had an even better comment with a link to the page... lost.
Too much #DevelopmentVelocity. I'll send a followup PR. |
samcunliffe
added a commit
that referenced
this pull request
Jun 14, 2023
Merged
willGraham01
pushed a commit
that referenced
this pull request
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic preliminaries. CMake, Windows SDK, Xcode etc.
Opening early in case anyone has time to scrutinise this. Still waiting for some feedback from @prmunro 's postdoc and should also sanity-test these on a Windows machine.Now tested on Windows, and I claim: ready for review.
I'll wait for Ed to email back some comments before merging (if he has a GH account he could even be invited to the review). This is probably good enough to go in around the same time as #320. Then we can patch.