HDF5 file structure reorganisation, and InterfaceComponent readability
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Trying to decipher structs * Further towards reading a struct * Bypass the stack-smash bug. MATLAB saves character arrays as uint16s, and HDF5 is unable to interpret them as chars. As such, we need to do manual conversion in the test. * Rename binary and update contents
…ility (#280) * Reorganise hdf5 unit tests - Move uint16 to char/str functions to the unit test utils file - Create hdf5_and_tdms_objects subdirectory of unit/ to hold unit tests on interaction between hdf5 and tdms classes - Move the Matrix<double> test from test_hdf5_io into the new subdirectory - Data files needed for unit tests are defined in a unit_test_utils namespace to avoid redefinition across multiple files * Create file to test interface and hdf5 interactions - Add docstrings to interface.h since these are missing and I've just had to work out what they do - Create a matlab script that can reproduce the class_data.mat file which the hdf5 unit tests will try to create tdms objects from - Create the barebones test_hdf5_interface file * HDF5Reader can read from .mat file and produce an InterfaceComponent * File restructure: accounting for how many tests we are going to have with HDF5 * Prune includes * Add .mat file for HDF5-TDMS-object unit tests to run. - Adds scripts to reproduce this data, so in theory a new user can run a short MATLAB script to reproduce this - Had a play with trying to get setup-matlab to run these scripts before the unit tests, but alas, no.
samcunliffe
commented
May 22, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
===================================
Coverage 25% 25%
===================================
Files 63 66 +3
Lines 3596 3607 +11
===================================
+ Hits 903 908 +5
- Misses 2693 2699 +6
☔ View full report in Codecov by Sentry. |
samcunliffe
added
the
review required
willGraham01
approved these changes
May 23, 2023
| // Read the InterfaceComponent in as a 2-element double array | ||
| double read_buffer[2]; | ||
| read_field_from_struct("interface", plane, read_buffer); | ||
| // The index that is read in should have 1 subtracted from it, to account for |
There was a problem hiding this comment.
Forward thinking here: if we/someone wants to also remove MATLAB from the input generation in the future, they'll need to develop some kind of workaround for these usage cases where we have to subtract one due to MATLAB indexing.
samcunliffe
commented
May 23, 2023
Co-authored-by: Will Graham <[email protected]>
willGraham01
approved these changes
May 23, 2023
This was referenced May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a single
git cherry-pickof the merge commit of #280 but now (eventually) targetingmain.Part of
Continues from
libhdf5and basic implementation class structure. #304Supercedes
Actual code notes and change description
... are in
HDF5file structure reorganisation, andInterfaceComponentreadability #280For future working, I think the "move files" and "add tests" steps here should have been separate PRs.
mainto ensure none of the review improvements are lost.