Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore intelliJ files #150

Merged
merged 2 commits into from
Apr 15, 2023
Merged

Ignore intelliJ files #150

merged 2 commits into from
Apr 15, 2023

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Apr 13, 2023

Especially annoying to have checkstyle fail the build due to the .idea folder.

@janhoy janhoy requested a review from a team as a code owner April 13, 2023 21:49
@ksclarke
Copy link
Member

ksclarke commented Apr 13, 2023 •
edited
Loading

I'm more of the mind that IDE files should be added to the dev's global .gitignore instead of adding to each individual project's .gitignore.

But, yes, though... we don't want them failing checkstyle. What's the checkstyle failure?

@ksclarke ksclarke self-assigned this Apr 13, 2023
@janhoy
Copy link
Contributor Author

janhoy commented Apr 13, 2023

But, yes, though... we don't want them failing checkstyle. What's the checkstyle failure?

They look like this

[INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ cantaloupe ---
[WARNING] .idea/workspace.xml:[1] (extension) newLineAtEndOfFileChecker: File does not end with a newline.

@ksclarke ksclarke merged commit f40e697 into UCLALibrary:main Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmatney markmatney markmatney approved these changes

@ksclarke ksclarke ksclarke approved these changes

Assignees

@ksclarke ksclarke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janhoy @ksclarke @markmatney