Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controlled Vocabulary Fix #181

Merged
merged 13 commits into from
Jan 10, 2022
Merged

Controlled Vocabulary Fix #181

merged 13 commits into from
Jan 10, 2022

Conversation

bkiahstroud
Copy link
Contributor

@bkiahstroud bkiahstroud commented Dec 1, 2021 •
edited
Loading

README

Merge #182 first

Summary

  • Fixed controlled vocabularies so they can be saved and edited
  • Removed lines in entrypoint.sh that were attempting to write to .bashrc which does not exist
  • Permit in_work_ids to pass through form. This fixed the unpermitted params error, but child works is still broke.
  • Attempt to fix authenticity token issue on staging by whitelisting notch8 staging URL

QA Testing Instructions

  • Can you log in on staging?
  • Create a new work and add any of the controlled vocab fields
  • Controlled vocab fields show up on work/show?
  • Edit controlled vocab fields

Screen_Shot_2021-11-19_at_1 44 12_PM

Screen_Shot_2021-11-19_at_1 44 45_PM

Sara G and others added 13 commits November 12, 2021 17:36
Merge branch 'move-ci' into 'n8-staging'
de87e75 
move gitlab-ci file

See merge request notch8/ucsc-library-digital-collections!54
fix nil error on show_all
a8a9661
search within collections
363cfc8
Merge branch 'i459-fix-collection-search' into 'n8-staging'
89d7955 
I459 collection search

See merge request notch8/ucsc-library-digital-collections!55
TEMPFIX: Move .gitlab-ci back to root
a84ed66
Merge branch 'move-gitlab-back' into 'n8-staging'
64318fd 
TEMPFIX: Move .gitlab-ci back to root

See merge request notch8/ucsc-library-digital-collections!56
registry variables
eb8a767
Merge branch 'registry-variables' into 'n8-staging'
0ec015c 
Registry Variables

See merge request notch8/ucsc-library-digital-collections!57
Revert "Merge branch 'registry-variables' into 'n8-staging'"
5f28a97 
This reverts merge request !57
Merge branch 'revert-0ec015ca' into 'n8-staging'
40320e5 
Revert "Merge branch 'registry-variables' into 'n8-staging'"

See merge request notch8/ucsc-library-digital-collections!58
Revert "Merge branch 'move-gitlab-back' into 'n8-staging'"
dcf7533 
This reverts merge request !56
Merge branch 'revert-64318fd7' into 'n8-staging'
e617f45 
Revert "Merge branch 'move-gitlab-back' into 'n8-staging'"

See merge request notch8/ucsc-library-digital-collections!59
Controlled Vocabs
8f2e1e1
@bkiahstroud bkiahstroud marked this pull request as ready for review December 1, 2021 19:02
rschwab
rschwab reviewed Dec 1, 2021
View reviewed changes
app/models/work.rb
# This section handles alternate date formates and standardizes them
::ScoobySnacks::METADATA_SCHEMA.fields.select{|name, field| field.input == "date"}.each do |field_name, field|
Copy link
Contributor

@rschwab rschwab Dec 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sara-g Did this sneak in from the work to remove Scooby Snacks, or is it part of making controlled vocabs work?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rschwab this was part of the work on date fields.

@snehagunduraoUL snehagunduraoUL merged commit 7f28ab2 into UCSCLibrary:staging Jan 10, 2022
@ShanaLMoore ShanaLMoore mentioned this pull request Nov 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschwab rschwab rschwab left review comments

@sara-g sara-g sara-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkiahstroud @rschwab @sara-g @snehagunduraoUL