-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20161109 bugfix in models.transition.remove_rows #177
Open
moritz-kirmse-forcity
wants to merge
5
commits into
UDST:master
Choose a base branch
from
moritz-kirmse-forcity:20161109_fix_remove
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
20161109 bugfix in models.transition.remove_rows #177
moritz-kirmse-forcity
wants to merge
5
commits into
UDST:master
from
moritz-kirmse-forcity:20161109_fix_remove
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
condition: the total to be removed with an accounting column is higher than the total of agents modification of remove_rows function so that the function does not abort
must check if accounting column is given before accessing columns for sum
Checking why tests have failed. |
I found 2 issues with this PR:
However, the bugfix remains valid even if the tests fail. |
temporary workaround for problem with random permutation
fix failed tests by updated pandas diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction for the following problem:
error handling is too strict:
whith accounting_column != None, the function won't allow removing an amount len(data) < nrows < data[accounting_columns].sum(), even if this is possible.