Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute max-profit over all forms if "form" is None #194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hanase
Copy link
Contributor

@hanase hanase commented May 3, 2017

This was a bug: If the argument "form" is None, the max profit should be computed over all forms.

When calling the function with form=None, the original code failed at the line df = df[df.max_profit_far > 0], since df.max_profit_far does not exist.

@coveralls
Copy link

coveralls commented May 3, 2017

Coverage Status

Coverage increased (+0.04%) to 94.335% when pulling d563ce7 on hanase:max-profit-fix into d9a058b on UDST:master.

@Eh2406
Copy link
Contributor

Eh2406 commented May 3, 2017

Good Catch! Maybe we should add a test to keep this from breaking again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants