Prune Sample Reductions #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When returning `header_only` we’re trying to provide macro level performance and metadata while omitting sample specific data which inflates the size the of the data. We are currently leaving `sample_reductions` when providing `header_only`, which can inflate the size of the headers file since it includes an entry for each sample (bad, for example, when model grading and each reduced sample carries an explanation from the model).
jjallaire
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning
header_onlywe’re trying to provide macro level performance and metadata while omitting sample specific data which inflates the size the of the data. We are currently leavingsample_reductionswhen providingheader_only, which can inflate the size of the headers file since it includes an entry for each sample (bad, for example, when model grading and each reduced sample carries an explanation from the model).This PR contains: