fix: osnap bot on disputed proposals

[Reinis-FRP]

Motivation

#4765 introduced side effects on oSnap bot:

• when proposing, it would not consider proposals that had been disputed (as intended by the fix), but this also extends to proposals from another snapshot votes that had been disputed and happens to have matching tx content with a new snapshot vote that has not been disputed since results of getUndiscardedProposals now can include also discarded proposals and are used as inputs in filterUnblockedProposals
• when disputing, it would consider all proposals, even those that had been disputed and are still in challenge window. this would result in bot error logging the failed dispute attempts since the proposal has been discarded from prior dispute
• when executing, it would also consider all disputed proposals that are past their challenge windows. this results in bot info logging the failed execution attempts since the proposal has been discarded by dispute.

Summary

This addresses the issue by splitting the getUndiscardedProposals in 2 functions (getAllProposals and filterUndiscardedProposals) and it is up to the caller which to use depending on context and reproposeDisputed flag.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

• Ran end-to-end test, running the code as in production
• New unit tests created
• Existing tests adequate, no new tests required
• All existing tests pass
• Untested

Issue(s)

Fixes #XXXX

[md0x]

nit: Should we call this removeDeletedProposals? I find the current name a bit confusing.

[Reinis-FRP]

makes sense, pushed the fix for rename

[md0x]

LGTM