Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: Do not use code hosted on polyfill.io. #946

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

cafuego
Copy link
Contributor

@cafuego cafuego commented Jun 27, 2024

Refs: OPS-10543

Copy link

Coverage Report

Totals Coverage
Statements: 8.98% ( 132 / 1470 )
Methods: 0% ( 0 / 16 )
Lines: 9.08% ( 132 / 1454 )

Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.3.8 (cli) (built: Jun 7 2024 02:48:40) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.8, Copyright (c) Zend Technologies with Zend OPcache v8.3.8, Copyright (c), by Zend Technologies with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.7.7 2024-06-10 22:11:12
Drupal Logs

Pusher: @cafuego, Action: pull_request, Workflow: Run tests

@lazysoundsystem
Copy link
Contributor

Grep shows it's also included in the choices library and the webform module:

../iasc8/html/libraries/choices/README.md
../iasc8/html/libraries/choices/public/index.html
../iasc8/html/modules/contrib/webform/webform.libraries.yml

it's also mentioned in the algolia.places library but only in comments.

There's a new version of webform https://www.drupal.org/project/webform/issues/3427662 but that module is also responsible for the choices library which hasn't yet been fixed: https://www.drupal.org/project/webform/issues/3457416

Copy link
Contributor

@lazysoundsystem lazysoundsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're not using webform, so my comment might be less important:
https://humanitarian.atlassian.net/browse/IASC-795

@lazysoundsystem
Copy link
Contributor

Webform updated in #947

@lazysoundsystem lazysoundsystem merged commit 1906995 into main Jul 4, 2024
2 checks passed
@lazysoundsystem lazysoundsystem deleted the security/ops-10543-polyfillio-problem branch July 4, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants