Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Composer Update #666

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Automatic Composer Update #666

merged 1 commit into from
Oct 19, 2023

Conversation

unocha-jenkins
Copy link
Contributor

Composer Update

Software Versions success

Software Versions PHP 8.2.11 (cli) (built: Oct 6 2023 09:47:18) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.11, Copyright (c) Zend Technologies with Zend OPcache v8.2.11, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.5.5 2023-03-21 11:50:05

Composer Outdated success

Composer Outdated composer/installers v1.12.0 ~ v2.2.0 A multi-framework ... drupal/coder 8.3.21 ! 8.3.22 Coder is a library... drupal/config_inspector 2.1.3 ! 2.1.4 Provides a configu... drupal/google_tag 1.6.0 ~ 2.0.2 Allows your websit... drupal/group 2.2.0 ~ 3.2.1 This module allows... drupal/inline_entity_form 1.0.0-rc15 ~ 2.0.0-rc9 Provides a widget ... drupal/maintenance200 1.1.0 ~ 2.1.0 Allows the mainten... drupal/social_auth_hid 3.2.0 ~ 4.0.0 Social Auth integr... drupal/subgroup 2.0.1 ~ 3.0.1 Allows you to stru... drupal/theme_switcher 1.3.0 ~ 2.0.1 Creates Theme Swit... drush/drush 11.6.0 ~ 12.3.0 Drush is a command... galbar/jsonpath 2.1 ~ 3.0 JSONPath implement... guzzlehttp/guzzle 7.7.1 ! 7.8.0 Guzzle is a PHP HT... league/commonmark 1.6.0 ~ 2.4.1 Highly-extensible ... phpunit/php-code-coverage 9.2.29 ~ 10.1.7 Library that provi... phpunit/phpunit 9.6.13 ~ 10.4.1 The PHP Unit Testi... rlanvin/php-rrule v2.3.1 ! v2.4.1 Lightweight and fa... unocha/common_design v8.2.0 ~ v9.2.1 OCHA Common Design... weitzman/drupal-test-traits 2.1.0 ! 2.2.0 Traits for testing... chi-teck/drupal-code-generator 2.6.2 ~ 3.2.0 Drupal code generator commerceguys/addressing v1.4.2 ~ v2.0.1 Addressing library... composer/semver 3.3.2 ! 3.4.0 Semver library tha... doctrine/annotations 1.14.3 ~ 2.0.1 Docblock Annotatio... doctrine/lexer 2.1.0 ~ 3.0.0 PHP Doctrine Lexer... drupal/social_api 3.1.0 ~ 4.0.1 Harmonizes social ... drupal/social_auth 3.1.0 ~ 4.1.0 Social Auth guzzlehttp/psr7 2.5.1 ! 2.6.1 PSR-7 message impl... phpstan/phpstan 1.10.38 ! 1.10.39 PHPStan - PHP Stat... phpunit/php-file-iterator 3.0.6 ~ 4.1.0 FilterIterator imp... phpunit/php-invoker 3.1.1 ~ 4.0.0 Invoke callables w... phpunit/php-text-template 2.0.4 ~ 3.0.1 Simple template en... phpunit/php-timer 5.0.3 ~ 6.0.0 Utility class for ... psy/psysh v0.11.21 ! v0.11.22 An interactive she... sebastian/cli-parser 1.0.1 ~ 2.0.0 Library for parsin... sebastian/code-unit 1.0.8 ~ 2.0.0 Collection of valu... sebastian/code-unit-reverse-lookup 2.0.3 ~ 3.0.0 Looks up which fun... sebastian/comparator 4.0.8 ~ 5.0.1 Provides the funct... sebastian/complexity 2.0.2 ~ 3.1.0 Library for calcul... sebastian/diff 4.0.5 ~ 5.0.3 Diff implementation sebastian/environment 5.1.5 ~ 6.0.1 Provides functiona... sebastian/exporter 4.0.5 ~ 5.1.1 Provides the funct... sebastian/global-state 5.0.6 ~ 6.0.1 Snapshotting of gl... sebastian/lines-of-code 1.0.3 ~ 2.0.1 Library for counti... sebastian/object-enumerator 4.0.4 ~ 5.0.0 Traverses array st... sebastian/object-reflector 2.0.4 ~ 3.0.0 Allows reflection ... sebastian/recursion-context 4.0.5 ~ 5.0.0 Provides functiona... sebastian/type 3.2.1 ~ 4.0.0 Collection of valu... sebastian/version 3.0.2 ~ 4.0.1 Library that helps... symfony/polyfill-ctype v1.27.0 ! v1.28.0 Symfony polyfill f... symfony/polyfill-iconv v1.27.0 ! v1.28.0 Symfony polyfill f... symfony/polyfill-intl-grapheme v1.27.0 ! v1.28.0 Symfony polyfill f... symfony/polyfill-intl-idn v1.27.0 ! v1.28.0 Symfony polyfill f... symfony/polyfill-intl-normalizer v1.27.0 ! v1.28.0 Symfony polyfill f... symfony/polyfill-mbstring v1.27.0 ! v1.28.0 Symfony polyfill f... symfony/polyfill-php83 v1.27.0 ! v1.28.0 Symfony polyfill b... symfony/psr-http-message-bridge v2.2.0 ! v2.3.1 PSR HTTP message b... twig/twig v3.6.1 ! v3.7.1 Twig, the flexible...

Composer UN-OCHA Outdated success

Composer UN-OCHA Outdated unocha/common_design v8.2.0 ~ v9.2.1 OCHA Common Design base theme for Drupa...

Composer Update success

Composer Update Output Gathering patches from patch file. Gathering patches from patch file. Gathering patches for dependencies. This might take a minute. - Applying patches for drupal/group https://www.drupal.org/files/issues/2022-05-04/i3278723.patch (https://www.drupal.org/project/subgroup/issues/3163044#comment-14499262) https://www.drupal.org/files/issues/2022-10-19/3212608-5_0.patch (https://www.drupal.org/project/group/issues/3212608 - views data export)

phpstan/extension-installer: Extensions installed

Composer Update Diagnostic Output Loading composer repositories with package information > scripts\composer\DrupalLenientRequirement::changeVersionConstraint Updating dependencies Lock file operations: 0 installs, 4 updates, 0 removals - Upgrading drupal/coder (8.3.21 => 8.3.22) - Upgrading drupal/config_inspector (2.1.3 => 2.1.4) - Upgrading drupal/group (2.2.0 => 2.2.1) - Upgrading phpstan/phpstan (1.10.38 => 1.10.39) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 0 installs, 4 updates, 0 removals - Downloading drupal/config_inspector (2.1.4) - Downloading phpstan/phpstan (1.10.39) - Downloading drupal/coder (8.3.22) - Downloading drupal/group (2.2.1) - Upgrading drupal/config_inspector (2.1.3 => 2.1.4): Extracting archive - Upgrading phpstan/phpstan (1.10.38 => 1.10.39): Extracting archive - Upgrading drupal/coder (8.3.21 => 8.3.22): Extracting archive - Upgrading drupal/group (2.2.0 => 2.2.1): Extracting archive Generating autoload files 98 packages you are using are looking for funding. Use the `composer fund` command to find out more! > git config core.hooksPath git-hooks || exit 0

Pusher: @cafuego, Action: schedule, Workflow: Run Composer Update

@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 45.95% ( 1566 / 3408 )
Methods: 26.14% ( 23 / 88 )
Lines: 46.48% ( 1543 / 3320 )

@github-actions
Copy link

Build output

Composer Validate `success`

PHP Lint `success`

Docker Build `success`

Environment Setup `success`

Site Install `success`

PHP Code Sniffer `success`

Software Versions

```PHP 8.2.11 (cli) (built: Oct 6 2023 09:47:18) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.11, Copyright (c) Zend Technologies
with Zend OPcache v8.2.11, Copyright (c), by Zend Technologies
with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans
Composer version 2.6.5 2023-10-06 10:11:52
```

Pusher: @unocha-jenkins, Action: `pull_request`, Workflow: `Run tests``;

@lazysoundsystem
Copy link
Contributor

@attiks - there's a warning on the Group release page - do you think I need to investigate further?

https://www.drupal.org/project/group/releases/2.2.1

Release notes

This fixes a critical bug that led to duplicate memberships or creator memberships not having the right roles assigned.

Warning: This introduces a behavioral change for code-generated groups' creators. If you have a group type configured to add a membership for the creator and require the creator to fill out their membership form, then code-created groups of that type will no longer generate a creator membership. This is to enforce the fact that you turned on the membership form and therefore probably rely on memberships to not have missing data.

All groups created through the UI will now behave as expected when it comes to their creator memberships. This change record details how code-generated groups now behave slightly differently.

Finally, if you suffered from this bug, your database may still have duplicate memberships in them. I strongly advise you to run this query to find them and then manually sort them out:

SELECT CONCAT('Group: ', gid, ' - User: ', entity_id) as Affected, GROUP_CONCAT(id, ',') as Relationships FROM group_relationship_field_data WHERE plugin_id = 'group_membership' GROUP BY gid, plugin_id, entity_id HAVING COUNT(id) > 1;

@attiks
Copy link
Contributor

attiks commented Oct 19, 2023

Code should be fine, but needs to be tested, can you deploy a branch to the staging server?

Copy link
Contributor

@lazysoundsystem lazysoundsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but will test further on staging.

@lazysoundsystem lazysoundsystem merged commit 7ad8326 into develop Oct 19, 2023
2 checks passed
@lazysoundsystem lazysoundsystem deleted the update/patch-70c6568 branch October 19, 2023 09:52
@lazysoundsystem
Copy link
Contributor

@attiks - as with UN-OCHA/iasc8#859 - checking if it's okay to deploy to stage as I think Content Squad have been testing there (though it looks like they've just finished).

@attiks
Copy link
Contributor

attiks commented Oct 19, 2023

It's OK

@lazysoundsystem
Copy link
Contributor

Created a new group and added a member. Calling this update okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants