Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RW-90] Use AWS SES api for subscriptions #478

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Conversation

orakili
Copy link
Collaborator

@orakili orakili commented Oct 5, 2022

Refs: RW-90

This adds the possibility to use the AWS SES API to send the RW notifications.

There is notably a config setting to select the method: smtp (current) and aws_ses_bulk_api.

This also refactors slightly the templates to remove the Read more link when there is no teaser (only title + meta) to slim down the emails and notably reduce the size of the jobs emails by removing this redundant link.

Note: Testing the SES API requires a mock server. The following was used for that: https://github.com/orakili/aws-ses-v2-local.

@orakili orakili marked this pull request as ready for review October 20, 2022 04:18
@orakili orakili requested a review from attiks October 20, 2022 04:18
attiks
attiks previously approved these changes Oct 24, 2022
@orakili orakili changed the title [RW-90] [WIP] Use aws SES api for subscritipions [RW-90] Use AWS SES api for subscriptions Oct 27, 2022
attiks
attiks previously approved these changes Nov 2, 2022
@orakili orakili added the blocked This PR is blocked, do not merge it label Jan 3, 2023
@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 11.54% ( 1092 / 9461 )
Methods: 11.61% ( 83 / 715 )
Lines: 11.54% ( 1009 / 8746 )

@github-actions
Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.10 (cli) (built: Sep 2 2023 06:59:22) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.10, Copyright (c) Zend Technologies with Zend OPcache v8.2.10, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.2 2023-09-03 14:09:15
Drupal Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

@attiks attiks self-requested a review September 19, 2023 07:44
@cafuego
Copy link
Contributor

cafuego commented May 1, 2024

I think this is superseded by our use of amazon_ses module.

@orakili
Copy link
Collaborator Author

orakili commented May 1, 2024

There are still things to salvage from this PR, notably the email templates. Keeping it open for when I have to time to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This PR is blocked, do not merge it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants