Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Inlcude the oipenid connect login block in config. #888

Closed
wants to merge 3 commits into from

Conversation

cafuego
Copy link
Contributor

@cafuego cafuego commented Sep 13, 2024

Refs: OPS-10834

Copy link

github-actions bot commented Sep 13, 2024

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions Docker version 26.1.3, build b72abbb PHP 8.3.11 (cli) (built: Aug 31 2024 04:39:21) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.11, Copyright (c) Zend Technologies with Zend OPcache v8.3.11, Copyright (c), by Zend Technologies with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.7.9 2024-09-04 14:43:28
Drupal Logs
PHP Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

Copy link

Coverage Report

Totals Coverage
Statements: 9.05% ( 1104 / 12194 )
Methods: 11.92% ( 82 / 688 )
Lines: 8.88% ( 1022 / 11506 )

Copy link
Collaborator

@orakili orakili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This results in the block being displayed on all environment sites. The block is not styled and appears above the login pages title:

Screenshot 2024-09-17 at 12 37 42

Locally, clicking the button results in a PHP error:

The website encountered an unexpected error. Try again later.

InvalidArgumentException: The URI '' is invalid. You must use a valid URI scheme. in Drupal\Core\Url::fromUri() (line 293 of core/lib/Drupal/Core/Url.php).
Drupal\openid_connect\Plugin\OpenIDConnectClientBase->authorize() (Line: 106)
Drupal\openid_connect\Form\OpenIDConnectLoginForm->submitForm()
call_user_func_array() (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers() (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm() (Line: 597)
Drupal\Core\Form\FormBuilder->processForm() (Line: 326)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 224)
Drupal\Core\Form\FormBuilder->getForm() (Line: 75)
Drupal\openid_connect\Plugin\Block\OpenIDConnectLoginBlock->build() (Line: 171)
Drupal\block\BlockViewBuilder::preRender()
call_user_func_array() (Line: 113)
Drupal\Core\Render\Renderer->doTrustedCallback() (Line: 870)
Drupal\Core\Render\Renderer->doCallback() (Line: 432)
Drupal\Core\Render\Renderer->doRender() (Line: 504)
Drupal\Core\Render\Renderer->doRender() (Line: 248)
Drupal\Core\Render\Renderer->render() (Line: 475)
Drupal\Core\Template\TwigExtension->escapeFilter() (Line: 200)
__TwigTemplate_d3fe6ad74fd2e4e639765dc0127608f8->block_main() (Line: 437)
Twig\Template->yieldBlock() (Line: 92)
__TwigTemplate_d3fe6ad74fd2e4e639765dc0127608f8->doDisplay() (Line: 393)
Twig\Template->yield() (Line: 143)
__TwigTemplate_79eb3eb02a5b2143072b8e5a13ea5109___532934100->doDisplay() (Line: 393)
Twig\Template->yield() (Line: 44)
__TwigTemplate_79eb3eb02a5b2143072b8e5a13ea5109->doDisplay() (Line: 393)
Twig\Template->yield() (Line: 349)
Twig\Template->display() (Line: 364)
Twig\Template->render() (Line: 35)
Twig\TemplateWrapper->render() (Line: 33)
twig_render_template() (Line: 348)
Drupal\Core\Theme\ThemeManager->render() (Line: 491)
Drupal\Core\Render\Renderer->doRender() (Line: 248)
Drupal\Core\Render\Renderer->render() (Line: 475)
Drupal\Core\Template\TwigExtension->escapeFilter() (Line: 89)
__TwigTemplate_1657b94d6be1ed9458a26947e48cad6e->doDisplay() (Line: 393)
Twig\Template->yield() (Line: 151)
__TwigTemplate_fc7d55ecb5861d2011c9f07df07c18ac___33734163->doDisplay() (Line: 393)
Twig\Template->yield() (Line: 44)
__TwigTemplate_fc7d55ecb5861d2011c9f07df07c18ac->doDisplay() (Line: 393)
Twig\Template->yield() (Line: 349)
Twig\Template->display() (Line: 364)
Twig\Template->render() (Line: 35)
Twig\TemplateWrapper->render() (Line: 33)
twig_render_template() (Line: 348)
Drupal\Core\Theme\ThemeManager->render() (Line: 491)
Drupal\Core\Render\Renderer->doRender() (Line: 248)
Drupal\Core\Render\Renderer->render() (Line: 158)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 153)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse() (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray()
call_user_func() (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (Line: 186)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Need some investigation on the error and work for the styling and display of the button.

@cafuego
Copy link
Contributor Author

cafuego commented Sep 18, 2024

Ahhh... annoying but fair.

@cafuego cafuego added the blocked This PR is blocked, do not merge it label Sep 18, 2024
@cafuego
Copy link
Contributor Author

cafuego commented Sep 24, 2024

Superseded by #899

@cafuego cafuego closed this Sep 24, 2024
@cafuego cafuego deleted the cafuego/ops-10834-entraid branch September 24, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This PR is blocked, do not merge it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants