Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Allow user to use relative path for bids uri #304

Merged
merged 8 commits into from
Jul 17, 2024

Conversation

arnaudbore
Copy link
Contributor

No description provided.

dependabot bot and others added 3 commits June 17, 2024 22:13
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.7 to 2.2.2.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.0.7...2.2.2)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@arnaudbore arnaudbore requested a review from SamGuay June 27, 2024 19:36
@SamGuay SamGuay changed the base branch from master to dev July 4, 2024 00:49
dependabot bot and others added 2 commits July 6, 2024 00:28
Bumps [certifi](https://github.com/certifi/python-certifi) from 2023.7.22 to 2024.7.4.
- [Commits](certifi/python-certifi@2023.07.22...2024.07.04)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should bring back the old tests just to be on the safe side.

Otherwise the feature works as intended.

@SamGuay SamGuay merged commit 989b185 into dev Jul 17, 2024
28 checks passed
@arnaudbore arnaudbore deleted the allow_user_to_use_old_way_intendedFor branch July 17, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants