Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primo commit #290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

primo commit #290

wants to merge 1 commit into from

Conversation

salvooowr
Copy link

No description provided.

@Picred
Copy link
Collaborator

Picred commented Oct 18, 2023

Per il messaggio di commit potresti usare i Conventional Commits

makapx
makapx suggested changes Oct 18, 2023
View reviewed changes
Copy link

@makapx makapx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dovresti uniformare l'indentazione, stai migliando spazi e tab vedo e il return è disallineato rispetto al resto del codice. Potresti spostare l'operazione di somma in un metodo a parte, da richiamare quando ti vendono dati i parametri in input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makapx makapx makapx requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salvooowr @Picred @makapx