Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: clustering playground critical facilities #123

Closed
wants to merge 3 commits into from

Conversation

kennethliporada
Copy link
Collaborator

Description

  • example cluster for critical facilities playground
  • this is only fire_station data

Screenshot

image

@jadurani jadurani changed the title feat:clustering playground critical facilities WIP: feat: clustering playground critical facilities Aug 13, 2021
@jadurani
Copy link
Contributor

Marked this as WIP -- the other critical facilities are not yet included. @kennethliporada kindly update with the other critical facilities and make sure the source names still match the ones in the previous dataset :)

@kennethliporada kennethliporada changed the title WIP: feat: clustering playground critical facilities WIP: clustering playground critical facilities Aug 13, 2021
@jadurani jadurani linked an issue Aug 18, 2021 that may be closed by this pull request
@jadurani
Copy link
Contributor

mapbox/mapbox-gl-js#2513

@jadurani
Copy link
Contributor

mapbox/mapbox-gl-js#2412

@kennethliporada
Copy link
Collaborator Author

Here po yung, its all about aggregation po yung nandito. di nya po sinupport yung question about clustering.

@jadurani
Copy link
Contributor

jadurani commented Aug 23, 2021

Here po yung, its all about aggregation po yung nandito. di nya po sinupport yung question about clustering.

Hi @kennethliporada. I asked last time to explain yung current situation, yung understanding mo, and yung blockers thoroughly. My expectation was that explanation would serve also as a documentation to anyone who does not have prior understanding about this ticket. Don't just send links. Explain the situation in your own words. Use the links as sources and get quotes from these sources but don't just send it like this.

As I've also repeatedly said, always push your WIP work on remote. I've said this many times already. Push your code sa remote kahit work in progress pa yan. Please don't make me repeat myself again.

The last commit here was made 11 days ago.

@kennethliporada
Copy link
Collaborator Author

kennethliporada commented Aug 23, 2021

Description

  • added multiple geojson file

Colors and names

  • Hospital = Blue
  • Fire = Red
  • Police Stations = Yellow
  • School = Green

Screenshots

  • Critical Facilities for PH
    image

  • Luzon
    image

  • Visayas
    image

  • Mindanao
    image

Errors

  • I have encountered errors po for clicking each unclustered points, for spike ko po yung errors nyan bale ito pong link na to for coordinates error. Yung isa di ko pa po alam kung bat sya nag error.

Screenshot Error

image

@jadurani
Copy link
Contributor

Thanks for the detailed update, @kennethliporada! 👏🏽 Keep it up 🎉

@jadurani
Copy link
Contributor

Again, comments and updates here please @kennethliporada

@kennethliporada
Copy link
Collaborator Author

Description

  • unclustered popup in playground critical facilities

Colors and Names

  • Hospital = Blue
  • Fire = Red
  • Police Stations = Yellow
  • School = Green

Loom

https://www.loom.com/share/7e684a9b6c844785ac1efe377f9ca1af

Encountered Error

image

  • still error po ako dito, yung dapat mag zoom yung cluster pag na click na.

@jadurani
Copy link
Contributor

closing this in favor of #150

@jadurani jadurani closed this Sep 29, 2021
@jadurani jadurani deleted the cluster/crit-pg branch October 7, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore clustering
2 participants