Starboard 2.0 #75
Starboard 2.0 #75
Conversation
|
alright i've made a few changes, mostly commenting. notably:
|
|
you can really tell i've spent so much time testing this pre-PR |
|
After conversations last night, I'm gonna mark this as a draft so it's not accidentally merged. Feel free to close it and start afresh @andrewj-brown |
I'll leave it up; honestly it would have been a draft from the start if I knew anything about Github's UI |
There was a problem hiding this comment.
LGTM, but I'll wait for another review as well (probably from @JamesDearlove ).
Some of the terminology (such as "big" and "whitelist"/"blacklist") was a little confusing, so a brief set of definitions at the top or slight name changes may be nice.
| if modlog is not None: | ||
| client.loop.create_task(modlog.send(message)) | ||
| else: | ||
| message += f" ...And also, I couldn't find #{MODLOG_CHANNEL_NAME} to log this properly." |
Starboard 2.0, implementing a bunch of stuff I originally ceebs'ed, plus novel features that committee discovered a need for:
Many of these features are only minimally tested. Prior to merging I'll need to get a few other people together in the testing server and make sure it's all fully functional.