Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quicker sign submit #414

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Conversation

dpgraham4401
Copy link
Member

@dpgraham4401 dpgraham4401 commented Mar 28, 2023

Description

This PR adds the ability to submit electronic (Quicker Sign) signatures from the (react) client. This also adjust the gating for the SyncManifestBtn, RcraApiUserBtn and the new QuickerSignModalBtn. The Quicker Sign Form has default values of the user's username and the current date. (however, we may consider remove the default username since we want the signature to be an intention action.

We also need to add front end validation for the QuickerSignForm.

The following general rules apply for the above buttons

  1. for SyncManifestBtn there must be a siteId to sync to
  2. for RcraApiUserBtn the user's profile must have apiUser set to true in the redux store (in thier RcraProfile)
  3. for QuickerSignModalBtn the manifest must be in either
    • "Scheduled"
    • "InTransit"
    • "ReadyForSignature"
      4.for QuickerSignModalBtn In addition, the signed property for the relevant ManifestHandler must be false
  4. For all, if the disabled prop is passed as true then the button should be disabled.

This PR fixes the above gating criteria for when the button can be used and also fixes the serializer signed property on the ManifestHandlerSerializer.

Issue ticket number and link

relevant to #412

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Other Stuff

@github-actions github-actions bot added server Related to backend workings (Django/Rest API) client Related to front end workings (React/Redux) test Unit tests are, or need to be, included labels Mar 28, 2023
@dpgraham4401 dpgraham4401 merged commit 8bd1125 into USEPA:main Mar 28, 2023
@dpgraham4401 dpgraham4401 deleted the quicker_sign_submit branch March 28, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Related to front end workings (React/Redux) server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant