Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ad hoc selectors #482

Merged
merged 10 commits into from
May 17, 2023

Conversation

dpgraham4401
Copy link
Member

@dpgraham4401 dpgraham4401 commented May 17, 2023

Description

This PR introduces real selectors into our project (something that should have been done a LONG time ago) so our redux state is encapsulated and the details remain hidden/abstracted from our components. This way we can change the structure of our redux state without having to change all our components that rely on that state.

Issue ticket number and link

closes #470

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions github-actions bot added server Related to backend workings (Django/Rest API) client Related to front end workings (React/Redux) test Unit tests are, or need to be, included labels May 17, 2023
@dpgraham4401 dpgraham4401 merged commit 834c5cf into USEPA:main May 17, 2023
@dpgraham4401 dpgraham4401 deleted the encaptsulate_with_selectors branch May 19, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Related to front end workings (React/Redux) server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace ad hoc selectors
1 participant