Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint config migration #756

Merged
merged 16 commits into from
Jul 31, 2024
Merged

Eslint config migration #756

merged 16 commits into from
Jul 31, 2024

Conversation

dpgraham4401
Copy link
Member

Description

migrates our eslint configurations to new flat config format (eslint.config.js). We also took this time to implement for strict eslint configs, and take advatnage of typescript-eslint. It's a little embarressing how out of date our eslint configs were lol.

Issue ticket number and link

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@dpgraham4401
ignore nextjs artifacts (from POC branch but ok to just have in here)
c33d8fe
@dpgraham4401
add eslint-config-react-app
4dc2b62
@dpgraham4401
init eslint config
d470afa
@dpgraham4401
fix common problems and remove rules requiring React to be in scope (…
9c0bd6d 
…we're React version > 17)
@dpgraham4401
misc eslint fixes
3b92a0d
@dpgraham4401
relax use of explicit any for eslint for migration purposes
8f77832
@dpgraham4401
ignore dist and build output directory for eslint, misc other fixes
902c58e
@dpgraham4401
typescript unused vars config and misc fixes
fdf179c
@dpgraham4401
fix additional miscelaneous errors
5f46d3b
@dpgraham4401
add prettier and jsxA11y eslint plugins to our new config
b6a6a23
@dpgraham4401
remove old eslint configs from package.json
684ad6c
@dpgraham4401
remove old unused dev dependencies include ts-jest (we don't use jest…
8de7673 
… anymore)
@dpgraham4401
migrate vitest to version > 2
772879a
@dpgraham4401
enable strict and stylistic typescript-eslint configs
8b0fa6e
@github-actions github-actions bot added client Related to front end workings (React/Redux) dependencies project dependency problems or modifications labels Jul 31, 2024
@dpgraham4401 dpgraham4401 merged commit 1990dc0 into USEPA:main Jul 31, 2024
10 checks passed
@dpgraham4401 dpgraham4401 deleted the eslint_config_migration branch July 31, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client Related to front end workings (React/Redux) dependencies project dependency problems or modifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpgraham4401