Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separated vdiagram data into two distinct types. #593

Merged
merged 1 commit into from
Feb 23, 2017
Merged

Separated vdiagram data into two distinct types. #593

merged 1 commit into from
Feb 23, 2017

Conversation

thongsav-usgs
Copy link
Collaborator

No description provided.

dpattermann-usgs
dpattermann-usgs approved these changes Feb 22, 2017
View reviewed changes
Copy link
Contributor

@dpattermann-usgs dpattermann-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, as long as the hasEnoughData function is right in what we do and don't need. That would be the only thing I would double check.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8db9bab on thongsav-usgs:master into ** on USGS-R:master**.

@thongsav-usgs thongsav-usgs merged commit 240666e into USGS-R:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpattermann-usgs dpattermann-usgs dpattermann-usgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thongsav-usgs @coveralls @dpattermann-usgs