-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup appeal sorting, improve appeal list styling #241
base: master
Are you sure you want to change the base?
Conversation
Best reviewed: commit by commit
Optimal code review plan (1 warning)
|
I'm concerned that the color changes are not assisting in our accessibility by not having a sufficient contrast ratio. The original colors were chosen for that reason. There is still an issue currently with blue and yellow rows having proper contrast ratio, but this new option now makes every URL pop up with an accessibility issue. For people I know either directly or indirectly, the new colors pose more of a struggle to use, and it creates even more white-space (which we already have enough of). This is why I initially rejected it in the last review. |
Everything but the yellow seems to stand out enough. |
Reviewing with whitespace changes ignored is recommended. (Files changed -> click gear icon -> enable "Hide whitespace changes" -> apply)
bg-*
classes, adds reserving admin to list. See screenshots:Current
New